Skip to content

Properly extract router.php from the Phar build#15

Merged
schlessera merged 2 commits intomasterfrom
13-extract-router
Mar 30, 2017
Merged

Properly extract router.php from the Phar build#15
schlessera merged 2 commits intomasterfrom
13-extract-router

Conversation

@danielbachhuber
Copy link
Member

The file needs to be extracted because php calls it directly.

Fixes #13

The file needs to be extracted because `php` calls it directly.
@danielbachhuber danielbachhuber added bug command:server Related to 'server' command labels Mar 30, 2017
@danielbachhuber danielbachhuber added this to the 1.0.1 milestone Mar 30, 2017
@danielbachhuber
Copy link
Member Author

@schlessera To verify this locally, you'll need to check out this branch of the wp-cli/server-command dependency, then run:

php -dphar.readonly=0 utils/make-phar.php wp-cli-nightly.phar --quiet

@schlessera schlessera merged commit 7d65b76 into master Mar 30, 2017
@schlessera schlessera deleted the 13-extract-router branch March 30, 2017 14:56
schlessera added a commit that referenced this pull request Jan 5, 2022
Properly extract router.php from the Phar build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug command:server Related to 'server' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants