Skip to content

Improve reporting when using --report-changed-only#57

Merged
gitlost merged 3 commits intowp-cli:masterfrom
LC43:fix/report-improvement
Dec 11, 2017
Merged

Improve reporting when using --report-changed-only#57
gitlost merged 3 commits intowp-cli:masterfrom
LC43:fix/report-improvement

Conversation

@LC43
Copy link
Contributor

@LC43 LC43 commented Dec 11, 2017

  1. when only reporting changes, if a table doesn't have primary keys, don't print any message.

  2. if the content of the table is empty, don't print the headers.

  3. added functional tests for ( using --report-changed-only )

  • when made 0 replacements, report should be empty

  • when a tables doesn't have a primary key, report should not contain the skipped table

improvement from #55

@gitlost gitlost merged commit 813977a into wp-cli:master Dec 11, 2017
@gitlost
Copy link
Contributor

gitlost commented Dec 11, 2017

Thanks @LC43 !

@danielbachhuber danielbachhuber changed the title Fix/report improvement Improve reporting when using --report-changed-only Dec 18, 2017
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants