Skip to content

Use empty string default value for flags to safeguard the use of explode()#169

Merged
schlessera merged 1 commit intowp-cli:masterfrom
cjhaas:cjhaas-php81-null-to-explode
Oct 17, 2022
Merged

Use empty string default value for flags to safeguard the use of explode()#169
schlessera merged 1 commit intowp-cli:masterfrom
cjhaas:cjhaas-php81-null-to-explode

Conversation

@cjhaas
Copy link
Contributor

@cjhaas cjhaas commented Feb 17, 2022

Fixes PHP 8.1 deprecation warning for passing null to explode.

See #168 for more details

@cjhaas cjhaas requested a review from a team as a code owner February 17, 2022 18:13
@Soean
Copy link
Contributor

Soean commented Oct 17, 2022

We have ran into the same issue, this change should fix the problem.

@schlessera How can we help here to get the problem fixed?

@schlessera schlessera force-pushed the cjhaas-php81-null-to-explode branch from 8aef9f5 to f5bad04 Compare October 17, 2022 21:50
@schlessera schlessera added this to the 2.0.19 milestone Oct 17, 2022
@schlessera schlessera merged commit f1a8a1d into wp-cli:master Oct 17, 2022
@schlessera schlessera changed the title Pass empty string for default value to get_flag_value when passing to explode Use empty string default value for flags to safeguard the use of explode() Oct 17, 2022
@cjhaas cjhaas deleted the cjhaas-php81-null-to-explode branch May 8, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants