Skip to content

Only try to unserialize strings #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schlessera merged 3 commits into from
Nov 13, 2020
Merged

Only try to unserialize strings #148

schlessera merged 3 commits into from
Nov 13, 2020

Conversation

@TimothyBJacobs
Copy link
Contributor

@TimothyBJacobs TimothyBJacobs commented Nov 12, 2020

Fixes #147.

@TimothyBJacobs TimothyBJacobs requested a review from a team as a code owner November 12, 2020 20:31
schlessera
schlessera requested changes Nov 13, 2020
View reviewed changes
@schlessera schlessera mentioned this pull request Nov 13, 2020
Closed
@schlessera
Copy link
Member

schlessera commented Nov 13, 2020

I had to change the framework dependency to pull in latest master, hopefully the tests will now pass.

@schlessera schlessera merged commit 70b4ba1 into wp-cli:master Nov 13, 2020
@schlessera schlessera added this to the 2.0.8 milestone Nov 13, 2020
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
@schlessera
Merge pull request #148 from TimothyBJacobs/fix/147
e933edf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlessera schlessera schlessera approved these changes

Assignees

No one assigned

Labels

bug command:search-replace

Projects

None yet

Milestone

2.0.8

Development

Successfully merging this pull request may close these issues.

PHP 8: Uncaught TypeError: unserialize(): Argument #1 ($data) must be of type string

2 participants

@TimothyBJacobs @schlessera