Only add commands if scaffold is already loaded.#104
Merged
danielbachhuber merged 3 commits intomasterfrom May 2, 2017
Merged
Conversation
With the new hooks introduced in wp-cli/wp-cli@7fcee0e , we can now only load the commands if the parent they depend on has already been added. This is needed because of the added flexibility provided by the bootstrap refactoring. See wp-cli/wp-cli#3872
Member
Author
|
@danielbachhuber Don't merge just yet, this is only added for testing the bootstrap stuff atm. In general, how do we go about updating commands if they require changes to the framework to work properly? |
schlessera
added a commit
to wp-cli/wp-cli
that referenced
this pull request
May 2, 2017
Member
Author
|
What's up with CircleCI? It seems to fail on loading Composer dependencies. Looks like it might have caching issues... |
Member
|
I think it's caching. |
This was referenced May 22, 2017
schlessera
pushed a commit
that referenced
this pull request
Aug 9, 2022
Only add commands if `scaffold` is already loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new hooks introduced in wp-cli/wp-cli@7fcee0e , we can now only load the commands if the parent they depend on has already been added.
This is needed because of the added flexibility provided by the bootstrap refactoring.
See wp-cli/wp-cli#3872