Skip to content

Trim dashicon string#70

Merged
gitlost merged 3 commits intowp-cli:masterfrom
ryotsun:strip-dashicon-string
Oct 18, 2017
Merged

Trim dashicon string#70
gitlost merged 3 commits intowp-cli:masterfrom
ryotsun:strip-dashicon-string

Conversation

@ryotsun
Copy link
Contributor

@ryotsun ryotsun commented Oct 17, 2017

Related #66

--dashicon=dashicon-info, --dashicon=dashicons-info and --dashicon=info
will be 'menu_icon' => 'dashicons-info'.

@ryotsun ryotsun force-pushed the strip-dashicon-string branch from 18b3e0d to 57e6071 Compare October 17, 2017 16:24
@ryotsun
Copy link
Contributor Author

ryotsun commented Oct 18, 2017

It seems that the Key has been expired.
https://travis-ci.org/wp-cli/scaffold-command/jobs/289112658#L403-L414

And it's failed because of timeout?

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

@ryotsun
Copy link
Contributor Author

ryotsun commented Oct 18, 2017

How can I re-run test on Travis?

@miya0001
Copy link
Member

@ryotsun I did. Thanks 😊

Copy link
Member

@miya0001 miya0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fro pull-request. 😊

@miya0001 miya0001 added the command:scaffold-post-type Related to 'scaffold post-type' command label Oct 18, 2017
@gitlost gitlost added this to the 1.0.11 milestone Oct 18, 2017
@gitlost gitlost merged commit 382bcff into wp-cli:master Oct 18, 2017
Then STDOUT should contain:
"""
'menu_icon' => 'dashicons-info',
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitlost Am I missing something or is this the same test, repeated?

@gitlost
Copy link
Contributor

gitlost commented Oct 18, 2017

Yes, I did a double-take also - there's an "s" in one and not the other.

@danielbachhuber
Copy link
Member

Ok. Please give me more ☕️ too.

danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:scaffold-post-type Related to 'scaffold post-type' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants