Skip to content

Add testsuite name in phpunit.xml.dist#310

Merged
schlessera merged 3 commits intowp-cli:masterfrom
wojsmol:add/testsuite-name
Jul 29, 2022
Merged

Add testsuite name in phpunit.xml.dist#310
schlessera merged 3 commits intowp-cli:masterfrom
wojsmol:add/testsuite-name

Conversation

@wojsmol
Copy link
Contributor

@wojsmol wojsmol commented Jul 28, 2022

Should fix tests for plugin scaffolding.

@wojsmol wojsmol requested a review from a team as a code owner July 28, 2022 18:38
@wojsmol wojsmol changed the title Add testsuite name in `phpunit.xml.dist Add testsuite name in phpunit.xml.dist Jul 28, 2022
@wojsmol wojsmol force-pushed the add/testsuite-name branch 2 times, most recently from 5f329e3 to 2b7831a Compare July 28, 2022 20:06
@schlessera
Copy link
Member

The tests are passing now, but you've disabled testing for WP 5.8+ now. Can you add another test scenario for WP 5.8+ that takes into account the change that WP did?

@schlessera schlessera added command:scaffold-plugin-tests Related to 'scaffold plugin-tests' command scope:testing Related to testing labels Jul 29, 2022
@wojsmol wojsmol force-pushed the add/testsuite-name branch from 7059c72 to af9ce5b Compare July 29, 2022 15:04
@wojsmol wojsmol force-pushed the add/testsuite-name branch from af9ce5b to 9fe8ed8 Compare July 29, 2022 15:22
@schlessera schlessera merged commit 275d2c3 into wp-cli:master Jul 29, 2022
@wojsmol wojsmol deleted the add/testsuite-name branch July 29, 2022 15:41
@danielbachhuber danielbachhuber added this to the 2.0.17 milestone Aug 12, 2022
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
Add testsuite name in `phpunit.xml.dist`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:scaffold-plugin-tests Related to 'scaffold plugin-tests' command scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants