Add --woocommerce flag to scaffold _s command#159
Merged
schlessera merged 3 commits intowp-cli:masterfrom Jul 20, 2018
Merged
Conversation
schlessera
requested changes
Jul 20, 2018
Member
schlessera
left a comment
There was a problem hiding this comment.
Looks great, @CodeProKid, only a minor code style change needed.
src/Scaffold_Command.php
Outdated
| * : Include stylesheets as SASS. | ||
| * | ||
| * [--woocommerce] | ||
| * : Include WooCommerce boilerplate files |
Member
There was a problem hiding this comment.
CS: End comments with a period ..
Contributor
Author
|
Thanks @schlessera, this has been fixed 👍 |
schlessera
approved these changes
Jul 20, 2018
--woocommerce flag to scaffold _s command
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
fixes #139 adding --woocommerce flag to scaffold _s command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the new --woocommerce flag to the scaffold _s command.
First time writing behat tests, so hopefully I got them right. The only test I wrote was basically to assert two of the WooCommerce files existed. Not sure if the tests should be more in depth than that, or if there should also be a test to assert the WooCommerce files don't exist when the flag isn't present.