-
Notifications
You must be signed in to change notification settings - Fork 10
Implement CS checking based on the WP_CLI_CS ruleset
#33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update .distignore and .gitignore with phpcs/phpunit config files Update wp-cli-tests to 2.1
schlessera
requested changes
Apr 21, 2019
jrfnl
reviewed
Apr 21, 2019
jrfnl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small remarks.
Fix CS in role-command.php, src/Capabilities_Command.php, src/Role_Command.php
1d6c31d to
9cb4c1e
Compare
schlessera
approved these changes
Apr 22, 2019
Member
|
I still added a few minor changes, @thrijith. As soon as the tests pass, this one can be merged. |
schlessera
pushed a commit
that referenced
this pull request
Jan 5, 2022
Implement CS checking based on the `WP_CLI_CS` ruleset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a PHPCS ruleset using the new
WP_CLI_CSstandard.Fixes #31
Related wp-cli/wp-cli#5179