Ok, the file is now being loaded twice, so you need to wrap a function_exists() check around the wpcli_assert_image_editor_support() function.

Silly, but there's no easy way I can think of to avoid that.

Hmm, maybe it is worth investigating why it is being loaded twice after all...

So wrapping the function in function_exists(), but it is just cloaking the fact that we're actually adding the command twice:

This is of course just the case when doing development on the command itself, but nevertheless, this bothers me.

Two solutions I can think of:

• Define a new pattern to make sure the command bootstrap file is only processed once (will probably need to be define based).
• Bail early if you try to add_command() a command that was already added (will need to investigate what this means for overrides).

Here's what I came up with so far.

This solves two problems:

• the file can be parsed multiple times without throwing an error (because I turned the regular function into a closure)
• the file can be executed multiple times without adding the command more than once (because of the define).

<?php

if ( defined( 'WP_CLI_MEDIA_COMMAND_LOADED' ) || ! class_exists( 'WP_CLI' ) ) {
	return;
}

define( 'WP_CLI_MEDIA_COMMAND_LOADED', true );

$wpcli_media_autoloader = dirname( __FILE__ ) . '/vendor/autoload.php';
if ( file_exists( $wpcli_media_autoloader ) ) {
	require_once $wpcli_media_autoloader;
}

/**
 * Check for Imagick and GD extensions availability.
 *
 * @throws \WP_CLI\ExitException
 */
$wpcli_media_assert_image_editor_support = function () {
	if ( ! wp_image_editor_supports() ) {
		WP_CLI::error(
			'No support for generating images found. '
			. 'Please install the Imagick or GD PHP extensions.'
		);
	}
};

WP_CLI::add_command(
	'media',
	'Media_Command',
	[ 'before_invoke' => $wpcli_media_assert_image_editor_support ]
);

How do you feel about that?

I can't really make up my mind just yet on a new pattern, so let's ignore the double-loading for this release.

To fix the broken tests, just turn the regular function into a closure:

/**
 * Check for Imagick and GD extensions availability.
 *
 * @throws \WP_CLI\ExitException
 */
$wpcli_media_assert_image_editor_support = function () {
	if ( ! wp_image_editor_supports() ) {
		WP_CLI::error(
			'No support for generating images found. '
			. 'Please install the Imagick or GD PHP extensions.'
		);
	}
};

WP_CLI::add_command(
	'media',
	'Media_Command',
	[ 'before_invoke' => $wpcli_media_assert_image_editor_support ]
);

I was away so couldn't reply faster, this seems fine #106 (comment).

so let's ignore the double-loading for this release.

Didn't get this part.

So, let's go with the last option then? The invoking function was a closure already, we now have better readability.