Skip to content

Conversation

@thrijith
Copy link
Member

@thrijith thrijith commented Apr 17, 2019

Add a PHPCS ruleset using the new WP_CLI_CS standard.

Fixes #4

Related wp-cli/wp-cli#5179

Copy link

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thrijith Just one small remark, other than that all looks good! 🎉

Update .distignore and .gitignore with phpcs/phpunit config files
Update wp-cli-tests to 2.1
@thrijith thrijith changed the title Implement CS checking based on the WPCliCS ruleset Implement CS checking based on the WP_CLI_CS ruleset Apr 19, 2019
Copy link

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that updated version is inline with the actual ruleset in the release ✔️

@schlessera schlessera merged commit db4671c into wp-cli:master Apr 19, 2019
@thrijith thrijith deleted the feature/use-phpcs branch April 19, 2019 15:45
@thrijith thrijith changed the title Implement CS checking based on the WP_CLI_CS ruleset Implement CS checking based on the WP_CLI_CS ruleset Apr 20, 2019
@schlessera schlessera modified the milestones: 2.0.0, 2.0.1 Apr 21, 2019
schlessera added a commit that referenced this pull request Jan 5, 2022
Implement CS checking based on the WP_CLI_CS ruleset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt and enforce new WP_CLI_CS standard

3 participants