Skip to content

Conversation

@pento
Copy link
Member

@pento pento commented Oct 4, 2021

When passing a category ID in the --category filter, the export will fail with the following error message:

Warning: Could not find a category matching 12345.

This PR fixes it by checking if the category is numeric, and casting it to an int.

@pento pento marked this pull request as ready for review October 4, 2021 23:57
@pento pento requested a review from a team as a code owner October 4, 2021 23:57
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me 👍

@pento pento changed the title Passing a category ID in --category causes the export to fail. Allow a category ID to be passed in the --category filter. Oct 5, 2021
@pento pento merged commit e810a01 into master Oct 5, 2021
@pento pento deleted the fix/category-id branch October 5, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants