Skip to content

Use Utils\esc_like() and remove internal esc_like().#79

Merged
schlessera merged 4 commits intomasterfrom
use-utils-esc_like
Jan 22, 2018
Merged

Use Utils\esc_like() and remove internal esc_like().#79
schlessera merged 4 commits intomasterfrom
use-utils-esc_like

Conversation

@gitlost
Copy link
Contributor

@gitlost gitlost commented Jan 15, 2018

Closes #66

Related #65 and wp-cli/wp-cli#4612

Uses new Utils\esc_like() and removes DB_Command::esc_like().

Changes require of wp-cli/wp-cli to >=1.5.0 in composer.json (is this the right way to do this? >= seems to work as uses dev-master whereas using caret or tilde fails with "Your requirements could not be resolved to an installable set of packages.").

@gitlost gitlost added this to the 1.3.3 milestone Jan 15, 2018
@schlessera
Copy link
Member

I think the recommended way is to use a limited dependency, like ^1.5, and then tell Composer what the current dev-master actually represents with a branch-alias in wp-cli/wp-cli:

    "extra": {
        "branch-alias": {
            "dev-master": "1.5.x-dev"
        }
    }

This way, the dev-master branch satisfies the ^1.5 requirement as well, provided that development versions are allowed.

@gitlost
Copy link
Contributor Author

gitlost commented Jan 16, 2018

Thanks, will do once packagist.org comes back online - seems to be having issues today...

@gitlost gitlost requested a review from a team January 21, 2018 17:19
@schlessera schlessera merged commit fec01e2 into master Jan 22, 2018
@schlessera schlessera deleted the use-utils-esc_like branch January 22, 2018 09:47
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
Use Utils\esc_like() and remove internal esc_like().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logic in DB_Command::esc_like() WP polyfill is not robust

2 participants