Fix retrieval of get_post_table_characterset #231
Merged
danielbachhuber merged 1 commit intowp-cli:masterfrom Oct 28, 2022
lipemat:fix-get-posts-table-charset
Merged
Fix retrieval of get_post_table_characterset
#231danielbachhuber merged 1 commit intowp-cli:masterfrom lipemat:fix-get-posts-table-charset
danielbachhuber merged 1 commit intowp-cli:masterfrom
lipemat:fix-get-posts-table-charset
Conversation
Query command run through `assoc_args_to_str` get double quotes truncated and fail to execute. Using single quotes in the query prevent error. `Warning: Failed to get current character set of the posts table. Reason: ERROR at line 1: Unknown command '\_'` Error may be more prominent on windows.
This was referenced Oct 14, 2022
danielbachhuber
approved these changes
Oct 28, 2022
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks @lipemat !
Landing so we can let it soak and see if any issues come up: wp-cli/wp-cli#5521 (comment)
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
Query command run through `assoc_args_to_str` get double quotes truncated and fail to execute. Using single quotes in the query prevent error. `Warning: Failed to get current character set of the posts table. Reason: ERROR at line 1: Unknown command '\_'` Error may be more prominent on windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query command run through
assoc_args_to_strget double quotes truncated and fail to execute.Using single quotes in the query prevent error.
Warning: Failed to get current character set of the posts table. Reason: ERROR at line 1: Unknown command '\_'Error may be more prominent on windows.