pass --column-statistics=0 to mysqldump command#105
Merged
schlessera merged 2 commits intomasterfrom Jul 31, 2018
Merged
Conversation
schlessera
approved these changes
Jul 20, 2018
schlessera
requested changes
Jul 20, 2018
src/DB_Command.php
Outdated
|
|
||
| $command = '/usr/bin/env mysqldump --no-defaults %s'; | ||
| $mysqldump_version = exec( "/usr/bin/env mysqldump --version --no-defaults" ); | ||
| $mysqldump_version = preg_replace( "/^.+([0-9]+\.[0-9]+\.[0-9]+)(.+)$/", "$1", $mysqldump_version ); |
Member
There was a problem hiding this comment.
This test does not take MariaDB into account.
Here's a version string from MariaDB from my current local setup:
$ /usr/bin/env mysqldump --version --no-defaults
mysqldump Ver 10.16 Distrib 10.2.14-MariaDB, for osx10.13 (x86_64)
So you not only need to check the version, but also whether you actually are using MySQL, not some variant.
Member
Author
|
I changed like following. Because |
schlessera
approved these changes
Jul 20, 2018
Member
|
Okay, let's try the change like this and monitor whether people still have issues with MySQL v8+ after that. |
This was referenced Jul 20, 2018
This was referenced Nov 3, 2019
domq
added a commit
to epfl-si/wp-ops
that referenced
this pull request
Jun 12, 2020
After epfl-si/polylang-cli@1d262be we no longer need this version pin. On the other hand, we need wp-cli/db-command#105 today, because our backups aree broken.
domq
added a commit
to epfl-si/wp-ops
that referenced
this pull request
Jun 12, 2020
After epfl-si/polylang-cli@1d262be we no longer need this version pin. On the other hand, we need wp-cli/db-command#105 today, because our backups aree broken.
GregLeBarbar
pushed a commit
to epfl-si/wp-ops
that referenced
this pull request
Jul 3, 2020
After epfl-si/polylang-cli@1d262be we no longer need this version pin. On the other hand, we need wp-cli/db-command#105 today, because our backups aree broken.
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
pass `--column-statistics=0` to mysqldump command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #103