Add ISO size formats to db size#104
Merged
schlessera merged 3 commits intowp-cli:masterfrom Jul 31, 2018
Merged
Conversation
schlessera
requested changes
Jul 20, 2018
src/DB_Command.php
Outdated
| * - gb (gigabytes) | ||
| * - tb (terabytes) | ||
| * - B (ISO Byte setting, with no conversion) | ||
| * - KB (ISO Kilobyte setting, with 1 kB = 1,000 B) |
Member
There was a problem hiding this comment.
Case is wrong in explanation. kB => KB
src/DB_Command.php
Outdated
| * - B (ISO Byte setting, with no conversion) | ||
| * - KB (ISO Kilobyte setting, with 1 kB = 1,000 B) | ||
| * - KiB (ISO Kibibyte setting, with 1 KiB = 1,024 B) | ||
| * - MB (ISO Megabyte setting, with 1 MB = 1,000 kB) |
Member
There was a problem hiding this comment.
Case is wrong in explanation. kB => KB
Contributor
Author
|
@schlessera Thank you for your review. Sorry for my typo and now they are fixed! |
miya0001
approved these changes
Jul 21, 2018
schlessera
approved these changes
Jul 31, 2018
Member
|
Thanks for the pull-request, @fumikito! |
db size
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
Add size formats as described in issue #102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hope it helps!