Remove only themes/plugins folders from archive.#156
Conversation
Contributor
|
@2crstn Please see failing tests. |
Author
|
Maybe the tests could be simplified. |
wojsmol
suggested changes
May 19, 2020
| """ | ||
| Success: WordPress downloaded. | ||
| """ | ||
| And the wp-includes directory should exist |
| """ | ||
| Success: WordPress downloaded. | ||
| """ | ||
| And the wp-includes directory should exist |
Author
|
Why only these two lines? There were more |
Contributor
|
@2crstn Please restore all |
Member
|
This couldn't be rebased, so closing in favor of #212 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #59 strips the whole
wp-contentdirectory, removinglanguagestoo and raising the issue that--locale=flag is broken.I just changed the if-statement to strip out
pluginsandthemesseparately.No idea how to write tests for that, it is a fairly simple fix.
Closes #147.