Strip wp-content/ using ZipArchive to allow --skip-content always#59
Merged
danielbachhuber merged 4 commits intomasterfrom Dec 11, 2017
Merged
Strip wp-content/ using ZipArchive to allow --skip-content always#59danielbachhuber merged 4 commits intomasterfrom
wp-content/ using ZipArchive to allow --skip-content always#59danielbachhuber merged 4 commits intomasterfrom
Conversation
gitlost
suggested changes
Dec 9, 2017
Contributor
gitlost
left a comment
There was a problem hiding this comment.
Also there're various temp files being left around in /tmp. I think the easiest way to deal with these is to use register_shutdown_function() to clean them up so I'll push a commit doing this, see what you think...
src/Core_Command.php
Outdated
| $bad_cache = false; | ||
| if ( $cache_file ) { | ||
| WP_CLI::log( "Using cached file '$cache_file'..." ); | ||
| if ( $skip_content ) { |
Contributor
There was a problem hiding this comment.
I think it'd be better to use a different variable here for the skip content file so as not to confuse things...
src/Core_Command.php
Outdated
| WP_CLI::warning( 'md5 hash checks are not available for nightly downloads.' ); | ||
| } | ||
|
|
||
| if ( $skip_content ) { |
Contributor
|
One job failed for "features/core-download.feature:179" on although https://api.wordpress.org/core/checksums/1.0/?version=5.0-alpha-42380&locale=en_US usually works. Restarting build... |
gitlost
approved these changes
Dec 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57