-
Notifications
You must be signed in to change notification settings - Fork 27
Implement CS checking based on the WP_CLI_CS ruleset
#62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update .distignore and .gitignore with phpcs/phpunit config files Update wp-cli-tests to 2.1
Fix CS in checksum-command.php src/Checksum_Base_Command.php src/Checksum_Core_Command.php src/Checksum_Plugin_Command.php src/WP_CLI/Fetchers/UnfilteredPlugin.php
thrijith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schlessera I have a few queries with the following changes.
schlessera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last change, and then this is good for merging.
jrfnl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just three more minor suggestions.
|
@thrijith I added a single minor change. If the tests pass, this can be merged. |
Implement CS checking based on the `WP_CLI_CS` ruleset
Add a PHPCS ruleset using the new
WP_CLI_CSstandard.Fixes #60
Related wp-cli/wp-cli#5179