Skip to content

Conversation

@thrijith
Copy link
Member

Add a PHPCS ruleset using the new WP_CLI_CS standard.

Fixes #60

Related wp-cli/wp-cli#5179

Update .distignore and .gitignore with phpcs/phpunit config files
Update wp-cli-tests to 2.1
Fix CS in checksum-command.php src/Checksum_Base_Command.php src/Checksum_Core_Command.php
src/Checksum_Plugin_Command.php src/WP_CLI/Fetchers/UnfilteredPlugin.php
@thrijith thrijith requested a review from a team as a code owner April 21, 2019 08:54
Copy link
Member Author

@thrijith thrijith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schlessera I have a few queries with the following changes.

Copy link
Member

@schlessera schlessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change, and then this is good for merging.

Copy link

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just three more minor suggestions.

@schlessera
Copy link
Member

@thrijith I added a single minor change. If the tests pass, this can be merged.

@thrijith thrijith merged commit e16dafd into master Apr 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/use-phpcs branch April 22, 2019 09:04
schlessera pushed a commit that referenced this pull request Dec 23, 2021
Implement CS checking based on the `WP_CLI_CS` ruleset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt and enforce new WP_CLI_CS standard

4 participants