Implement CS checking based on the WP_CLI_CS ruleset
#54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
reviewed
Apr 17, 2019
47e3329 to
a9ddc76
Compare
3 tasks
... as that version contains the new WPCliCS PHPCS standard.
* `.distignore`: no need to distribute the phpcs/phpunit config files.
* `.gitignore`: Allow devs to overwrite config files for PHPUnit and PHPCS
- The `.dist` files should be committed. However, for their personal use, devs can overrule those files with versions without `.dist`.
Those personal versions should never be committed.
As a side-note: for PHPCS, having a personal version while still using the original `.dist` file is made very easy, as you can just import the `.dist` file as a starting point, like so:
```xml
<?xml version="1.0"?>
<ruleset name="WP-CLI">
<rule ref="./phpcs.xml.dist"/>
</ruleset>
```
The file is completely documented in-line.
Only minimal changes needed.
a9ddc76 to
77c232d
Compare
schlessera
approved these changes
Apr 19, 2019
WP_CLI_CS ruleset
schlessera
added a commit
that referenced
this pull request
Dec 23, 2021
Implement CS checking based on the WPCliCS ruleset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically adds a PHPCS ruleset using the new
WPCliCSstandard, fixes a few minor infractions and whitelists some others.Please see the individual commits for more detail.
The build for this PR won't be able to pass until
wp-cli-tests2.1has been released, upon which time, the build can just be restarted and should be green ;-)[Edit]: this PR presumes that the https://github.com/wp-cli/cache-command/tree/prefix-global-variables branch will be pulled & merged before that time. /cc @schlessera
Fixes #55
Related wp-cli/wp-cli#5179