Skip to content

chore: formatting cleanup and dependency pruning [v8]#1439

Merged
nicknisi merged 3 commits intoversion-8from
nicknisi/v8-formatting-cleanup
Jan 8, 2026
Merged

chore: formatting cleanup and dependency pruning [v8]#1439
nicknisi merged 3 commits intoversion-8from
nicknisi/v8-formatting-cleanup

Conversation

@nicknisi
Copy link
Member

@nicknisi nicknisi commented Jan 8, 2026

Summary

  • Remove unused devDependencies: @types/cookie, @types/glob, @types/qs, baseline-browser-mapping, glob, nock, supertest
  • Remove deprecated /* eslint-env node */ comments (globals already defined in eslint config for .cjs files)
  • Fix formatting/linting issues across interface files and serializers

@nicknisi nicknisi requested a review from a team as a code owner January 8, 2026 14:58
@nicknisi nicknisi requested review from ericroberts and removed request for a team January 8, 2026 14:58
@nicknisi nicknisi changed the title chore: formatting cleanup and dependency pruning chore: formatting cleanup and dependency pruning [v8] Jan 8, 2026
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR performs maintenance cleanup by removing unused dependencies and standardizing code formatting across the codebase. All removed dependencies (@types/cookie, @types/glob, @types/qs, baseline-browser-mapping, glob, nock, supertest) were verified to be unused in the current codebase.

Key Changes:

  • Removed 7 unused devDependencies from package.json, reducing package footprint
  • Removed deprecated /* eslint-env node */ comments from Jest configuration files (globals are already defined in ESLint config for .cjs files)
  • Standardized interface formatting across 30+ interface declarations, consolidating multi-line extends clauses to single lines for consistency
  • Applied consistent code formatting to test files and serializers

Impact:

  • Smaller dependency tree and faster npm install
  • Improved code consistency and readability
  • No functional changes to the codebase
  • All changes are purely cosmetic/maintenance

Confidence Score: 5/5

  • This PR is safe to merge with no risk - purely cosmetic changes with no functional impact
  • Score reflects that this is a low-risk maintenance PR with only formatting changes and dependency removals. All removed dependencies were verified as unused, and formatting changes are purely cosmetic with no logic modifications. No custom security rules were violated.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
package.json 5/5 Removed 7 unused devDependencies that are no longer referenced in the codebase
package-lock.json 5/5 Automatically updated to reflect removal of 7 devDependencies from package.json
src/common/interfaces/event.interface.ts 5/5 Consolidated interface declarations to single lines for better readability
src/api-keys/interfaces/create-organization-api-key-options.interface.ts 5/5 Reformatted interface with added eslint disable comment for empty object type

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Lint as ESLint/Prettier
    participant Deps as Package Manager
    participant Code as TypeScript Interfaces
    
    Dev->>Deps: Remove unused devDependencies
    Note over Deps: Remove @types/cookie, @types/glob,<br/>@types/qs, baseline-browser-mapping,<br/>glob, nock, supertest
    Deps->>Deps: Update package-lock.json
    
    Dev->>Lint: Remove deprecated eslint-env comments
    Note over Lint: Comments removed from .cjs files<br/>(globals already in config)
    
    Dev->>Code: Run formatter on interfaces
    Note over Code: Consolidate multi-line interface<br/>declarations to single lines
    
    Code->>Lint: Apply formatting rules
    Lint->>Code: Format event.interface.ts (30+ interfaces)
    Lint->>Code: Format user-management interfaces
    Lint->>Code: Format serializers & spec files
    
    Code->>Dev: All formatting applied
    Dev->>Dev: Clean, consistent codebase
Loading

@nicknisi nicknisi merged commit 91c8e1e into version-8 Jan 8, 2026
8 checks passed
@nicknisi nicknisi deleted the nicknisi/v8-formatting-cleanup branch January 8, 2026 16:28
nicknisi added a commit that referenced this pull request Jan 9, 2026
## Summary

- Remove unused devDependencies: `@types/cookie`, `@types/glob`,
`@types/qs`, `baseline-browser-mapping`, `glob`, `nock`, `supertest`
- Remove deprecated `/* eslint-env node */` comments (globals already
defined in eslint config for `.cjs` files)
- Fix formatting/linting issues across interface files and serializers
nicknisi added a commit that referenced this pull request Jan 12, 2026
## Summary

- Remove unused devDependencies: `@types/cookie`, `@types/glob`,
`@types/qs`, `baseline-browser-mapping`, `glob`, `nock`, `supertest`
- Remove deprecated `/* eslint-env node */` comments (globals already
defined in eslint config for `.cjs` files)
- Fix formatting/linting issues across interface files and serializers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants