Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

Avoid testing for focus if there is nothing focused#104

Merged
koke merged 1 commit intomasterfrom
fix-is-focused
Dec 20, 2018
Merged

Avoid testing for focus if there is nothing focused#104
koke merged 1 commit intomasterfrom
fix-is-focused

Conversation

@koke
Copy link
Copy Markdown
Member

@koke koke commented Dec 20, 2018

Fixes some problems with the test renderer calling this. There was something wrong in the Jest test isolation in wordpress-mobile/gutenberg-mobile#423, it was calling when this was unmounted with a null focused field

Fixes some problems with the test renderer calling this
@koke koke requested a review from mzorz December 20, 2018 20:22
koke added a commit to wordpress-mobile/gutenberg-mobile that referenced this pull request Dec 20, 2018
Copy link
Copy Markdown
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice workaround @koke so we make sure not to go with null
Tested, works, LGTM :shipit:

Test Suites: 4 passed, 4 total
Tests:       10 passed, 10 total
Snapshots:   0 total
Time:        26.508s
Ran all test suites.

@koke koke merged commit 11c30e2 into master Dec 20, 2018
@koke koke deleted the fix-is-focused branch December 20, 2018 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants