Skip to content

Improve accessibility on missing block#959

Merged
koke merged 4 commits intodevelopfrom
issue/a11y-unsupported
May 10, 2019
Merged

Improve accessibility on missing block#959
koke merged 4 commits intodevelopfrom
issue/a11y-unsupported

Conversation

@koke
Copy link
Copy Markdown
Member

@koke koke commented May 6, 2019

Fixes #950

To test

With VoiceOver/Talkback activated

  1. Create a post with some unsupported blocks (gallery, contact form)
  2. Tap on the unsupported gallery block, it should read Unsupported block: Gallery
  3. Tap on the unsupported contact form (any non-core block), it should read Unsupported block

@koke koke added Accessibility [Type] Enhancement Improves a current area of the editor labels May 6, 2019
@koke koke added this to the v1.5 milestone May 6, 2019
@koke koke requested a review from etoledom May 6, 2019 11:34
@koke koke marked this pull request as ready for review May 6, 2019 11:51
@koke koke added the Blocks label May 6, 2019
@koke
Copy link
Copy Markdown
Member Author

koke commented May 6, 2019

I’ve tested this on iOS but not yet on android

Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koke koke merged commit 13edd35 into develop May 10, 2019
@koke koke deleted the issue/a11y-unsupported branch May 10, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessibility Blocks [Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve screen reader support for Unsupported Block

2 participants