Skip to content

Improve accessibility on missing block#15457

Merged
koke merged 5 commits intomasterfrom
rnmobile/a11y-unsupported
May 10, 2019
Merged

Improve accessibility on missing block#15457
koke merged 5 commits intomasterfrom
rnmobile/a11y-unsupported

Conversation

@koke
Copy link
Copy Markdown
Contributor

@koke koke commented May 6, 2019

@koke koke requested a review from etoledom May 6, 2019 11:34
@koke koke added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels May 6, 2019
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @koke for improving Accessibility 🎉

I added a couple of comments, but it's working great!

Comment thread packages/block-library/src/missing/edit.native.js Outdated
Comment thread packages/block-library/src/missing/edit.native.js Outdated
etoledom and others added 2 commits May 7, 2019 09:25
Co-Authored-By: koke <jbernal@gmail.com>
Co-Authored-By: koke <jbernal@gmail.com>
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!
Feel free to :shipit: when ✅ from CI

@koke koke merged commit 94d48e0 into master May 10, 2019
@koke koke deleted the rnmobile/a11y-unsupported branch May 10, 2019 11:05
@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve screen reader support for Unsupported Block

3 participants