Merged
Conversation
Revert some changes to yarn.lock
Delete package-lock.json
…/appium-improvements
…github.com/wordpress-mobile/gutenberg-mobile into revert-803-revert-676-try/e2e-tests-appium
CircleCI: Use API 28 for Android build
Generated by 🚫 dangerJS |
1 task
1 task
etoledom
approved these changes
Apr 19, 2019
Contributor
etoledom
left a comment
There was a problem hiding this comment.
My tests on iOS side look good! ✅
marecar3
approved these changes
Apr 19, 2019
Contributor
marecar3
left a comment
There was a problem hiding this comment.
LGTM!
Even we found a couple of issues on Android when using List Block, it's ok to merge this one as iOS doesn't have those kinds of issues.
Contributor
|
Removing approve as maybe we should consider disabling List Block on Android until we fix some of the issues that we found on the release day : Here is the list of bugs regarding List Block : |
Contributor
|
Yes, as we've been chatting in Slack, let's ship the List block for iOS but hold it back for Android until the important issues are fixed. |
…on-android Suppress the List block on Android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges
release/1.3.0tomasterfor the next releases of the WPiOS/WPAndroid apps.Related PR on WPiOS: wordpress-mobile/WordPress-iOS#11502
Related PR on Aztec iOS: wordpress-mobile/AztecEditor-iOS#1176
Related PR on WPAndroid: wordpress-mobile/WordPress-Android#9668
Related PR on Aztec Android: N/A