Revert some changes to yarn.lock#805
Merged
jtreanor merged 1 commit intorevert-803-revert-676-try/e2e-tests-appiumfrom Apr 2, 2019
Merged
Revert some changes to yarn.lock#805jtreanor merged 1 commit intorevert-803-revert-676-try/e2e-tests-appiumfrom
jtreanor merged 1 commit intorevert-803-revert-676-try/e2e-tests-appiumfrom
Conversation
hypest
approved these changes
Apr 2, 2019
Contributor
hypest
left a comment
There was a problem hiding this comment.
LGTM!
Let's merge to the parent PR and we do more extensive testing for possible regressions in that one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#676 inadvertently made a very large number of changes to
yarn.lock(> 2,000 lines added).We reverted the PR earlier today because Jitpack builds started to fail.
This PR reverts the large number of changes to
yarn.lock(I just reverted the changes and ranyarn).You can see that the build now passes on Jitpack here.