Skip to content

[iOS] Activate autoscroll on ListBlock#890

Merged
etoledom merged 6 commits intodevelopfrom
issue/autoscroll-on-list-block
May 1, 2019
Merged

[iOS] Activate autoscroll on ListBlock#890
etoledom merged 6 commits intodevelopfrom
issue/autoscroll-on-list-block

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Apr 18, 2019

This PR updates the gutenberg ref to test WordPress/gutenberg#15048

This activates autoscroll on iOS when the caret is out of the viewport area (i.e. goes behind the keyboard).

lists-autoscroll

To test:

  • Create a list block.
  • Add elements until the caret will go under the keyboard.
  • Check that the block scrolls to show the caret.

@etoledom etoledom added [Type] Enhancement Improves a current area of the editor [OS] iOS labels Apr 18, 2019
@etoledom etoledom added this to the v1.3 milestone Apr 18, 2019
@etoledom etoledom requested a review from pinarol April 18, 2019 15:34
@etoledom etoledom self-assigned this Apr 18, 2019
@etoledom etoledom mentioned this pull request Apr 18, 2019
Merged
@mzorz
Copy link
Copy Markdown
Contributor

mzorz commented Apr 18, 2019 •
edited
Loading

Just tried this PR with words other than Asdf and it crashes with a red screen :trollface:

@hypest
Copy link
Copy Markdown
Contributor

hypest commented Apr 19, 2019

Moving this to next milestone as it needs some more testing (as per @pinarol ) and it can't make it to today's cut.

@hypest hypest modified the milestones: v1.3, v1.4 Apr 19, 2019
pinarol
pinarol approved these changes Apr 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so great! Working pretty well on heading, paragraph and list blocks 🎉

@etoledom etoledom merged commit d46cebd into develop May 1, 2019
@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented May 1, 2019

Thank you!

@etoledom etoledom deleted the issue/autoscroll-on-list-block branch May 1, 2019 07:37
Tug added a commit that referenced this pull request May 2, 2019
@Tug
Squashed commit of the following:
014bb9c 
commit 72f934e
Merge: c935c81 d46cebd
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu May 2 10:32:48 2019 +0300

    Merge branch 'develop' into fix/list-handling-in-android

commit c935c81
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu May 2 09:48:36 2019 +0300

    Don't use a lambda, to avoid bringing in Java8 features

commit d46cebd
Merge: 42d8443 09f1ca7
Author: etoledom <etoledom@icloud.com>
Date:   Wed May 1 09:37:06 2019 +0200

    Merge pull request #890 from wordpress-mobile/issue/autoscroll-on-list-block

    [iOS] Activate autoscroll on ListBlock

commit 04610cc
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Wed May 1 00:56:33 2019 +0300

    Need to include the kotlin plugin dep location

commit 52832ce
Merge: 897d272 42d8443
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Wed May 1 00:26:57 2019 +0300

    Merge branch 'develop' into fix/list-handling-in-android

commit 897d272
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Wed May 1 00:11:36 2019 +0300

    Set Aztec t delete the Enter for paragraph block

commit ca2a93f
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Tue Apr 30 20:24:28 2019 +0300

    Update GB from its master

commit 0417343
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Tue Apr 30 19:58:53 2019 +0300

    Utilize isEnterPressedUnderway

commit 991f8a8
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Tue Apr 30 18:10:09 2019 +0300

    Use Aztec helper isEnterPressedUnderway

commit 09f1ca7
Merge: 61b52cb 42d8443
Author: etoledom <etoledom@icloud.com>
Date:   Tue Apr 30 13:26:04 2019 +0200

    Merge branch 'develop' into issue/autoscroll-on-list-block

commit 61b52cb
Author: etoledom <etoledom@icloud.com>
Date:   Tue Apr 30 13:25:10 2019 +0200

    Update gutenberg ref to master

commit 57c8de0
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Fri Apr 26 15:13:02 2019 +0300

    Use a git tag to try please JitPack

commit ab4f3e3
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Fri Apr 26 15:07:33 2019 +0300

    Use shortened hash version to try please JitPack

commit ce92f47
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Fri Apr 26 14:43:16 2019 +0300

    Update Aztec ref

commit 7897f98
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu Apr 25 16:07:12 2019 +0300

    Update Aztec ref

commit 76678c9
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu Apr 25 15:13:06 2019 +0300

    Minimize diff

commit cd97945
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu Apr 25 13:03:12 2019 +0300

    Update GB hash

commit c3f094a
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu Apr 25 12:44:16 2019 +0300

    Update GB hash

commit 7391049
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu Apr 25 12:02:19 2019 +0300

    Update GB hash

commit 70112bf
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu Apr 25 04:11:43 2019 +0300

    Update GB hash

commit 91c222e
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu Apr 25 03:21:56 2019 +0300

    Update GB hash to use iOS regression fixes

commit 1786fab
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu Apr 25 03:20:19 2019 +0300

    Use simplified access to EnterPressedUnderway

commit 166b206
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu Apr 25 03:15:37 2019 +0300

    Remove temporary code

commit d17e5d2
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu Apr 25 02:05:01 2019 +0300

    Use Aztec ref with the Enter processing fix

commit bbda142
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu Apr 25 02:00:41 2019 +0300

    Use the GB hash with the rich-text fix

commit 8889b8d
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Thu Apr 25 01:58:58 2019 +0300

    Don't emit text changed event when Enter detected

    The Enter event (ReactAztecEnterEvent) will have the text that the RN
    side needs to process through the format-lib and hopefully match Aztec's
    processing.

commit 38cdc59
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Tue Apr 23 11:54:54 2019 +0300

    Use passed selection when Enter already altered text

commit 2372231
Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com>
Date:   Tue Apr 23 10:11:51 2019 +0300

    Signal if text has already been changed

commit 1a4f344
Author: etoledom <etoledom@icloud.com>
Date:   Fri Apr 19 18:14:16 2019 +0200

    Update gutenberg ref

commit abc09d1
Merge: c6ca773 0be0fa2
Author: etoledom <etoledom@icloud.com>
Date:   Fri Apr 19 17:49:27 2019 +0200

    Merge branch 'develop' into issue/autoscroll-on-list-block

commit c6ca773
Author: etoledom <etoledom@icloud.com>
Date:   Fri Apr 19 17:49:17 2019 +0200

    Update gutenberg ref

commit a521284
Author: etoledom <etoledom@icloud.com>
Date:   Thu Apr 18 17:01:53 2019 +0200

    Update gutenberg ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinarol pinarol pinarol approved these changes

Assignees

@etoledom etoledom

Labels

[OS] iOS [Type] Enhancement Improves a current area of the editor

Projects

None yet

Milestone

v1.4

Development

Successfully merging this pull request may close these issues.

4 participants

@etoledom @mzorz @hypest @pinarol