[iOS] Deactivate Tab and Shift+Tab key shortcuts#889
Merged
Conversation
This is a shortcut to update Carthage.lock file when the Aztec reference is updated.
This was referenced Apr 18, 2019
Contributor
Author
|
Thank you! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a part of #888
Related Aztec PR: wordpress-mobile/AztecEditor-iOS#1175
This PR removes the Tab and Shift+Tab key shortcuts.
On a second iteration of the ListBlock, we will want to reactivate them using gutenberg internal mechanism.
I also removed the
Tabkey functionality completely. It was adding tab characters to the content of blocks, and also breaking the ListBlock. This is different to how it works on Android and Web, so I don't see any harm on deactivating it until we handle it properly (cc @hypest )IMHO, the functionality we want for the Tab key in this case is to move the focus to the next block, in the same way it works on web.
To test Tabs:
To test Shift+Tabs: