Skip to content

Refactor TextView key commands.#1175

Merged
etoledom merged 1 commit intodevelopfrom
issue/refactor-public-independent-key-commands
Apr 18, 2019
Merged

Refactor TextView key commands.#1175
etoledom merged 1 commit intodevelopfrom
issue/refactor-public-independent-key-commands

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Apr 18, 2019

Refactor TextView key commands to make key commands publicly and independently accessible.

This is needed to override override open var keyCommands: [UIKeyCommand]? using the key commands defined internally by Aztec, without depending on the array indexing of them.

This PR has no change in logic.

To test:

Copy link
Copy Markdown
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@etoledom etoledom merged commit fa048d2 into develop Apr 18, 2019
@etoledom
Copy link
Copy Markdown
Contributor Author

Thank you!

@etoledom etoledom deleted the issue/refactor-public-independent-key-commands branch April 18, 2019 15:20
@jtreanor jtreanor mentioned this pull request Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants