Merged
Conversation
SergioEstevao
approved these changes
Mar 22, 2019
Contributor
SergioEstevao
left a comment
There was a problem hiding this comment.
Working well on the demo app! Tested on iPhone XR, iPhone X and iPad on multiple split-view modes.
Contributor
Author
|
Thank you both! |
This was referenced Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #604
This PR implements a JS only version of the iOS Readable Content Margins. This help us to show a narrower content view when the screens are too wide.
In the original ticket, @iamthomasbishop opted to keep the native iOS Readable Content Guide, but I opted for a simpler first iteration with a fixed maximum width. And later on implement platform specific details.
To test Android:
gutenberg-mobilesubmodule.To test iOS: