Skip to content

[Gutenberg] Readable content margins#11316

Merged
etoledom merged 3 commits intodevelopfrom
issue/gutenberg-readable-content-margins
Mar 26, 2019
Merged

[Gutenberg] Readable content margins#11316
etoledom merged 3 commits intodevelopfrom
issue/gutenberg-readable-content-margins

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Mar 21, 2019

This PR makes the necessary changes to show properly the readable content margins implemented here: wordpress-mobile/gutenberg-mobile#769

ReadableContent

To test:

  • Run the project on an iPad.
  • Be sure to have Metro running on the issue/604-add-readable-margins branch.
  • Start an instance of Gutenberg.
  • Make sure that the content is centered as shown in the screenshots.
  • Run the project on an iPhone X or XS Max.
  • On portrait, make sure that there are not side borders on selected blocks.
  • On landscape, check that the content is centered and there are side borders on selected blocks.

@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Mar 21, 2019
@etoledom etoledom added this to the 12.1 milestone Mar 21, 2019
@etoledom etoledom self-assigned this Mar 21, 2019
@etoledom etoledom requested a review from SergioEstevao March 21, 2019 17:48
@etoledom etoledom mentioned this pull request Mar 21, 2019
Merged
@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Mar 22, 2019

@SergioEstevao - I've updated this branch from develop to incorporate the last Gutenberg changes.
This should fix the red screen on Gutenberg load.

@etoledom etoledom modified the milestones: 12.1, 12.2 Mar 22, 2019
@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Mar 22, 2019 •
edited
Loading

Since we didn't add wordpress-mobile/gutenberg-mobile#769 to the gutenberg-mobile v1.1.1 release, let's move this PR to the WPiOS 12.2 milestone and not merge until the next code freeze.

@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Mar 26, 2019

Hey @SergioEstevao - I believe this is safe to merge now. Would you mind to do a review please?

Thank you! 🙏

SergioEstevao
SergioEstevao approved these changes Mar 26, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking all good now!

@etoledom etoledom merged commit 8ee19b2 into develop Mar 26, 2019
@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Mar 26, 2019

Thank you!

@etoledom etoledom deleted the issue/gutenberg-readable-content-margins branch March 26, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees

@etoledom etoledom

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

12.2

Development

Successfully merging this pull request may close these issues.

2 participants

@etoledom @SergioEstevao