Merged
Conversation
Result of running the following: ``` npx @rnx-kit/align-deps@latest --write --requirements react-native@0.73 ```
Revert changes that are incompatible with the Gutenberg project because they are a undesired downgrade or erroneously modify usage of the `^` version annotation. Specifically for Jest, this sets the version to match the version used in Gutenberg core.
The result of `npm install` after update React Native-related dependencies for 0.73.
These packages were renamed, the old names are deprecated.
The previous lock file was incorrect, as it was the result of running `npm install` after merely bumping package version numbers. In order to capture the correct lock file results, one must follow the Gutenberg project's guidelines for updating dependencies, which involves removing and re-adding each dependency. This now captures the result of `npm install` after following that process. https://github.com/WordPress/gutenberg/tree/c7cf2f74f38ae4c1f325e3238e61270a801f183c/packages#updating-existing-dependencies
…-native-0.73-metro-changes Update Metro config
Required for compatibility with React Native 0.73.
This method no longer exists after the React Native 0.73 upgrade. It is also no longer necessary.
This is the result of running the following command. ``` npm run xcframework:build ``` It also required deleting the `Podfile.lock` entirely, as installing pods failed due a loop of errors and requests to update individual pods in search of compatible versions between pods.
Without wrapping this in `act` an error is thrown in the test.
Some CLI commands were hoisted from the dedicated CLI package into React Native core. Without React Native installed in the top level of this project, scripts will fail due to missing commands. This is considered a workaround currently. It would be ideal to avoid the need to duplicate this dependency that is already within the Gutenberg core project, but it may be unavoidable due to the CLI changes in core.
This reverts commit e09ff7f.
13 tasks
Contributor
|
Contributor
🟢 Accessibility (Android)Build: jetpack-prototype-build-pr20167-0a4fe24.apk
|
Contributor
🟢 Functionality Tests (Android)Build: jetpack-prototype-build-pr20167-0a4fe24.apk 🟢 Test Suite 1Gallery - 1
Gallery - 2
MediaText - 1
MediaText - 2
MultipleUpload - 1
Cover - 1
Editor Theme - 1🟢 Test Suite 2DarkMode - 1
Group - 1
Buttons-1
Button-2
Button-3
Color Settings - 1Image - 1
Drag and Drop Blocks - 1
VideoPress - 2🟢 Test Suite 3Gallery - 2
Gallery - 3MediaText - 3
MediaText - 4Shortcode-1
Cover - 2
Image - 2🟢 Test Suite 4Group - 2
Buttons - 4
Buttons - 5
Buttons - 7
Editor Theme - 2Color Settings - 2VideoPress - 1🟢 Test Suite 5Video block - 1
Video block - 2
File block - 1
File block - 2
File block - 3
Audio block - 1
Audio block - 2
Audio block - 3
Audio block - 4
Synced patterns - 1Synced patterns - 2Embed block - 1
Embed block - 2
🟢 Drag & Drop
|
Member
🟡 Basic Test Suite Checklist (iOS)Build: pr22588-68c1ea9 Writing FlowRich Text Format
Splitting and merging
Unsupported Block
Gallery Block |
Member
🟢 Accessibility (iOS)Build: pr22588-68c1ea9
|
Member
🟢 Functionality Tests (iOS)Build: wordpress-mobile/WordPress-iOS#22588 (comment) 🟢 Test Suite 1Gallery - 1
Gallery - 2
MediaText - 1
MediaText - 2
MultipleUpload - 1
Cover - 1
Editor Theme - 1🟢 Test Suite 2DarkMode - 1
Group - 1
Buttons-1
Button-2
Button-3
Color Settings - 1Image - 1
Drag and Drop Blocks - 1
VideoPress - 2🟢 Test Suite 3Gallery - 2
Gallery - 3MediaText - 3
MediaText - 4Shortcode-1
Cover - 2
Image - 2🟢 Test Suite 4Group - 2
Buttons - 4
Buttons - 5
Buttons - 7
Editor Theme - 2Color Settings - 2VideoPress - 1🟢 Test Suite 5Video block - 1
Video block - 2
File block - 1
File block - 2
File block - 3
Audio block - 1
Audio block - 2
Audio block - 3
Audio block - 4
Synced patterns - 1Synced patterns - 2Embed block - 1
Embed block - 2
🟢 Drag & Drop
|
geriux
reviewed
Feb 23, 2024
…react-native-0.73 # Conflicts: # gutenberg # ios-xcframework/Podfile.lock
…react-native-0.73 # Conflicts: # gutenberg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs
0.73.3Upgrade WordPress-Android#20167Description
This PR is generated by
version-toolkitto downstream the changes forgutenbergsubmodule.