Update Metro config#6618
Merged
dcalhoun merged 5 commits intoversion-toolkit/gutenberg/build/upgrade-to-react-native-0.73from Feb 8, 2024
Merged
Conversation
dcalhoun
approved these changes
Feb 8, 2024
Member
dcalhoun
left a comment
There was a problem hiding this comment.
The Metro server successfully starts with this, so I think we should merge this and iterate on it. Thank you!
| projectRoot: path.resolve( __dirname ), | ||
| resolver: { | ||
| ...gutenbergMetroConfig.resolver, | ||
| unstable_enableSymlinks: false, |
Member
There was a problem hiding this comment.
I think we may be able to keep this enabled. I may follow up with a refactor later.
Comment on lines
+33
to
+39
| // This handles part of the Jetpack Config setup typically handled by Webpack's externals. | ||
| if ( moduleName.startsWith( '@automattic/jetpack-config' ) ) { | ||
| return { | ||
| filePath: path.resolve( __dirname + '/src/jetpack-config.js' ), | ||
| type: 'sourceFile', | ||
| }; | ||
| } |
a73d6ac
into
version-toolkit/gutenberg/build/upgrade-to-react-native-0.73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
To test:
PR submission checklist: