Update E2E tests bundle script for iOS#6287
Merged
Merged
Conversation
added 2 commits
October 16, 2023 17:25
…is recently changed with the Hermes update for iOS but it needs to be bundled from Gutenberg Mobile to add the extra features, like capabilities and added strings.
e5262ce to
f178731
Compare
dcalhoun
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #6281 (comment) where it was found that the recent Hermes changes introduced a change in the behavior of how the E2E bundle is done for the iOS Gutenberg Mobile tests.
The PR that introduced the Hermes changes was generating the iOS bundle from Gutenberg instead of Gutenberg Mobile, this was causing different behaviors compared to the Android platform where some tests would have different strings.
This now unifies both platforms to generate the bundles from Gutenberg Mobile.
To test CI checks should pass.
PR submission checklist: