Skip to content

GutenbergDemo app: Enable Hermes #6154

Merged
geriux merged 6 commits into
trunkfrom
update-demo-app-hermes
Sep 28, 2023
Merged

GutenbergDemo app: Enable Hermes #6154
geriux merged 6 commits into
trunkfrom
update-demo-app-hermes

Conversation

@geriux

@geriux geriux commented Sep 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related PRs:

This PR enables Hermes in the Demo app.

It removes the usage of test:e2e:bundle:ios in favor of using the command from Gutenberg npm run core test:e2e:bundle:ios this way we only need to keep updated in one place.

Due to using Hermes on iPad the visual E2E tests were loading a very large test content which was affecting the stability of the test so I updated it to just have the content the test needed.

Lastly, it updates a visual snapshot for the Unsupported block editor.

To test CI checks should pass, including Full E2E tests.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Testing Anything related to automated tests label Sep 4, 2023
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Sep 4, 2023 •
edited
Loading

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Sep 4, 2023

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

1 similar comment
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Sep 4, 2023

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux mentioned this pull request Sep 5, 2023
Merged
@geriux geriux force-pushed the update-demo-app-hermes branch 3 times, most recently from 5243a92 to 75c35ab Compare September 6, 2023 17:31
@geriux geriux force-pushed the update-demo-app-hermes branch 4 times, most recently from 5d62af2 to 1cc16a1 Compare September 27, 2023 12:21
@geriux geriux marked this pull request as ready for review September 27, 2023 12:26
@twstokes twstokes self-requested a review September 27, 2023 14:45
twstokes
twstokes approved these changes Sep 27, 2023
View reviewed changes

@twstokes twstokes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @geriux! All tests passed. 🚀

@geriux geriux force-pushed the update-demo-app-hermes branch from 1cc16a1 to f171667 Compare September 28, 2023 11:00
@geriux geriux added this to the 1.106.0 (23.5) milestone Sep 28, 2023
@geriux geriux merged commit 9a9eab5 into trunk Sep 28, 2023
@geriux geriux deleted the update-demo-app-hermes branch September 28, 2023 12:19
@dcalhoun dcalhoun mentioned this pull request Oct 13, 2023
Merged
2 tasks
@geriux geriux mentioned this pull request Oct 16, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twstokes twstokes twstokes approved these changes

Assignees

No one assigned

Labels

Testing Anything related to automated tests

Projects

None yet

Milestone

1.106.0 (23.5)

Development

Successfully merging this pull request may close these issues.

2 participants

@geriux @twstokes