[Mobile] - GutenbergDemo app: Enable Hermes#54151
Merged
Merged
Conversation
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
|
Flaky tests detected in edc6d8e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6325817041
|
2 tasks
ed82d96 to
286de6f
Compare
f2c5b29 to
71183e8
Compare
geriux
commented
Sep 26, 2023
| target 'GutenbergDemo' do | ||
| # Comment the next line if you don't want to use dynamic frameworks | ||
| use_frameworks! | ||
| use_frameworks! linkage: :static |
Member
Author
There was a problem hiding this comment.
Without this it was failing, it replicates the same usage from the XCFramework see its Podfile config.
5bbb73c to
edc6d8e
Compare
twstokes
approved these changes
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR adds support to use Hermes on the iOS Demo App.
Why?
We are already using Hermes in the host iOS app, so it makes sense to use it in the Demo app as well, as this is where we run our E2E tests and typically build some features. This approach ensures that we test and develop using the same engine.
How?
It updates the bundle scripts to use Hermes functionalities like bytecode bundles.
Removes the Reanimated patch since it's not needed anymore.
Due to the cache we have for npm modules, it updates to a minor version of
react-native-url-polyfillto trigger a new installation of npm modules. This update includes some fixes and does not introduce any breaking changes.Testing Instructions
CI checks should pass.
Local build should run with metro.
Screenshots or screencast
N/A