Skip to content

[RNMobile] Bump react-native-gesture-handler to version 2.3.2#4895

Merged
fluiddot merged 9 commits intotrunkfrom
version-toolkit/gutenberg/rnmobile/update/react-native-gesture-handler-2.3.2
May 27, 2022
Merged

[RNMobile] Bump react-native-gesture-handler to version 2.3.2#4895
fluiddot merged 9 commits intotrunkfrom
version-toolkit/gutenberg/rnmobile/update/react-native-gesture-handler-2.3.2

Conversation

@wpmobilebot
Copy link
Copy Markdown
Collaborator

@wpmobilebot wpmobilebot commented May 25, 2022 •
edited by fluiddot
Loading

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented May 25, 2022 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot self-assigned this May 25, 2022
@fluiddot fluiddot added the dependencies Pull requests that update a dependency file label May 25, 2022
@fluiddot fluiddot added this to the 1.77.0 milestone May 25, 2022
@fluiddot fluiddot requested a review from geriux May 25, 2022 16:44
fluiddot
fluiddot reviewed May 25, 2022
View reviewed changes
third-party-podspecs/RNReanimated.podspec.json
{
"name": "RNReanimated",
"version": "2.4.1-wp-1",
"version": "2.4.1-wp-2",
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we forgot to update the version of Reanimated after merging the drag & drop functionality.

Copy link
Copy Markdown
Contributor

@fluiddot fluiddot May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked what we included in version wp-2 and it was just a fix for Android (reference), so this change will have no impact on iOS 😅 .

@SiobhyB SiobhyB modified the milestones: 1.77.0, 1.78.0 May 27, 2022
geriux
geriux approved these changes May 27, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This worked as expected, I was able to build de demo app and the main apps locally. Do we need to update the bundles with these changes?

@fluiddot
Copy link
Copy Markdown
Contributor

fluiddot commented May 27, 2022

LGTM! This worked as expected, I was able to build de demo app and the main apps locally. Do we need to update the bundles with these changes?

Yep, good catch! I'll generate the bundle and test it again, thanks for the tip 🙇 !

@fluiddot fluiddot enabled auto-merge May 27, 2022 15:32
@fluiddot fluiddot merged commit dbb191b into trunk May 27, 2022
@fluiddot fluiddot deleted the version-toolkit/gutenberg/rnmobile/update/react-native-gesture-handler-2.3.2 branch May 27, 2022 16:00
@fluiddot fluiddot mentioned this pull request Jun 10, 2022
Merged
4 tasks
@fluiddot fluiddot modified the milestones: 1.79.0 (20.2), 1.78.0 (20.1) Jun 13, 2022
@fluiddot fluiddot mentioned this pull request Jun 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@fluiddot fluiddot fluiddot left review comments

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fluiddot fluiddot

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

1.78.0 (20.1)

Development

Successfully merging this pull request may close these issues.

4 participants

@wpmobilebot @fluiddot @geriux @SiobhyB