Skip to content

[Gutenberg] Bump react-native-gesture-handler to version 2.3.2#18742

Merged
fluiddot merged 3 commits intogutenberg/after_1.77.0from
gutenberg/update/react-native-gesture-handler-2.3.2
May 30, 2022
Merged

[Gutenberg] Bump react-native-gesture-handler to version 2.3.2#18742
fluiddot merged 3 commits intogutenberg/after_1.77.0from
gutenberg/update/react-native-gesture-handler-2.3.2

Conversation

@fluiddot
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot commented May 26, 2022 •
edited
Loading

To test:
Observe that drag & drop functionality works as expected.

Regression Notes

  1. Potential unintended areas of impact
    None apart of the editor.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the Gutenberg Editing and display of Gutenberg blocks. label May 26, 2022
@fluiddot fluiddot added this to the 20.0 milestone May 26, 2022
@fluiddot fluiddot requested a review from geriux May 26, 2022 10:31
@fluiddot fluiddot self-assigned this May 26, 2022
@fluiddot fluiddot mentioned this pull request May 26, 2022
Merged
@fluiddot fluiddot marked this pull request as ready for review May 26, 2022 10:34
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 26, 2022 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18742-4be634f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 26, 2022 •
edited
Loading

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18742-4be634f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@fluiddot fluiddot mentioned this pull request May 26, 2022
Merged
geriux
geriux approved these changes May 27, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it worked correctly 🚀

@fluiddot
Copy link
Copy Markdown
Contributor Author

fluiddot commented May 27, 2022

I tested using the build pr18742-51fa1bf and confirm that the Drag & Drop functionality works as expected 🎊 .

@fluiddot
Copy link
Copy Markdown
Contributor Author

fluiddot commented May 27, 2022

Heads up that I'm changing the target branch to gutenberg/after_1.77.0 as the 1.77.0 release was recently cut.

@fluiddot fluiddot changed the base branch from trunk to gutenberg/after_1.77.0 May 27, 2022 15:00
@fluiddot fluiddot modified the milestones: 20.0, 19.8.1, 20.1 May 27, 2022
@fluiddot fluiddot force-pushed the gutenberg/update/react-native-gesture-handler-2.3.2 branch from 51fa1bf to 4be634f Compare May 27, 2022 17:02
@fluiddot fluiddot merged commit e6a05e6 into gutenberg/after_1.77.0 May 30, 2022
@fluiddot fluiddot deleted the gutenberg/update/react-native-gesture-handler-2.3.2 branch May 30, 2022 08:03
@SiobhyB SiobhyB mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fluiddot fluiddot

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

20.1

Development

Successfully merging this pull request may close these issues.

3 participants

@fluiddot @wpmobilebot @geriux