Audio block capability now enables/disables media upload's media sources by jd-alexander · Pull Request #3523 · wordpress-mobile/gutenberg-mobile

jd-alexander · 2021-05-19T02:53:24Z

WordPress iOS wordpress-mobile/WordPress-iOS#16533
WordPress Android wordpress-mobile/WordPress-Android#14680
Gutenberg WordPress/gutenberg#31966

To test:
WordPress/gutenberg#31966

PR submission checklist:

I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

peril-wordpress-mobile · 2021-05-19T03:02:38Z

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

jd-alexander · 2021-05-24T16:30:16Z

@fluiddot I am going to be finalizing these set of PRs soon with the capabilities changes. While working on this on Friday, I noticed the translation related failure while trying to build the bundle to test on iOS. I am assuming that I have to utilize the string-extract-fix patch and localization files from 1.52.2 you created for the previous release to get this working as expected. Let me know what you think.

fluiddot · 2021-05-24T16:50:25Z

@fluiddot I am going to be finalizing these set of PRs soon with the capabilities changes. While working on this on Friday, I noticed the translation related failure while trying to build the bundle to test on iOS. I am assuming that I have to utilize the string-extract-fix patch and localization files from 1.52.2 you created for the previous release to get this working as expected. Let me know what you think.

Yeah, I'd recommend you to use the patch and the localization files from 1.52.2 to produce the proper localization strings files. However, if you're not introducing new strings, probably you could skip modifying those files in this PR and use the ones we currently have on develop branch.

Btw, I've just checked the commit "Merge branch 'develop' into add/audio-block-capability" and I saw that some of the strings have been pushed with conflicts.

jd-alexander · 2021-05-25T03:40:53Z

Yeah, I'd recommend you to use the patch and the localization files from 1.52.2 to produce the proper localization strings files. However, if you're not introducing new strings, probably you could skip modifying those files in this PR and use the ones we currently have on develop branch.

Thanks for the tips. I haven't updated this PR as yet as I was investigating the hermes crash which is a blocker for this PR since I would need to sync with the latest gb-mobile develop and gb trunk.

jd-alexander · 2021-05-27T04:27:13Z

Since there are changes within the main apps PR apart from the gutenberg-mobile ref changes, I will be creating a gutenberg-mobile tag of v1.54.0-alpha2 when this PR is approved.

@fluiddot when I run npm run bundle with or without the patch I was getting genstring failures so I am not sure if the translation changes here aren't to be expected. Let me know. Thanks! I am going to give the PR you created and related discussions a thorough review to understand how translations work because I haven't had a look at the code generation logic in detail.

jd-alexander · 2021-05-27T05:18:19Z

I did re-runs of Gutenberg Editor Slash Inserter tests but I am still getting failures. The changes here are unrelated as far as I am concerned.

fluiddot · 2021-05-27T11:13:09Z

Since there are changes within the main apps PR apart from the gutenberg-mobile ref changes, I will be creating a gutenberg-mobile tag of v1.54.0-alpha2 when this PR is approved.

👍

@fluiddot when I run npm run bundle with or without the patch I was getting genstring failures so I am not sure if the translation changes here aren't to be expected. Let me know. Thanks! I am going to give the PR you created and related discussions a thorough review to understand how translations work because I haven't had a look at the code generation logic in detail.

Yikes, could you share the failures that you got when generating the bundle?

I see that these changes have a new string (Insert from URL) in the code but I verified that it's already in the Gutenberg translations (GlotPress reference) so it's expected that no modification is made to the localization strings files that we push to the main apps.

bundle/android/strings.xml
bundle/ios/GutenbergNativeTranslations.swift

However, I saw the translation files (i18n-data files) have been modified and they are missing strings (you can check that by opening any of them (es.json) and look for the word block title). I'll apply the fixes from the PR that should help us with this issue.

fluiddot · 2021-05-27T11:15:54Z

I did re-runs of Gutenberg Editor Slash Inserter tests but I am still getting failures. The changes here are unrelated as far as I am concerned.

This was fixed yesterday via this PR so if you update the branch with develop it should be fixed 🎊 .

# Conflicts: # bundle/ios/App.js # bundle/ios/App.js.map # gutenberg

fluiddot · 2021-05-31T17:21:48Z

@jd-alexander Heads up that I've updated all the PRs for doing final testing, the only changes I made are:

Fix indent issues on Gutenberg props
Merge conflicts with develop

Let me know if you have any concerns regarding these updates, thanks 🙇 !

jd-alexander · 2021-06-01T02:50:04Z

Let me know if you have any concerns regarding these updates, thanks 🙇 !

I have no issue with these updates. Thanks @fluiddot 🙇🏾

fluiddot · 2021-06-01T08:07:51Z

RELEASE-NOTES.txt

@@ -1,3 +1,7 @@
+Unreleased
+------
+* [***] Audio block now available on WP.com sites on the free plan. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/3523]


I moved this entry to the unreleased section as this PR won't be included in 1.54.0.

fluiddot · 2021-06-01T08:10:53Z

I changed the milestone of this PR to 1.55.0 (17.6) as the 1.54.0 version is already cut.

fluiddot

Approved via WordPress/gutenberg#31966 (review).

# Conflicts: # bundle/ios/App.js.map

jd-alexander added [Type] Task Audio block labels May 19, 2021

jd-alexander force-pushed the add/audio-block-capability branch from 81aa6db to 7a1e60c Compare May 19, 2021 03:45

jd-alexander changed the base branch from develop to add/audio-block-IV-from-url May 19, 2021 03:46

jd-alexander marked this pull request as ready for review May 20, 2021 03:46

jd-alexander requested a review from fluiddot May 20, 2021 03:46

jd-alexander added this to the 1.54.0 (17.5) milestone May 20, 2021

Base automatically changed from add/audio-block-IV-from-url to develop May 21, 2021 05:45

jd-alexander added 3 commits May 26, 2021 19:53

added release notes.

bbdbabd

updated gutenberg ref.

f78d6b5

updated bundle

f314419

jd-alexander force-pushed the add/audio-block-capability branch from 6a0e564 to f314419 Compare May 27, 2021 01:26

jd-alexander added 3 commits May 26, 2021 22:04

Updated gutenberg ref.

f49fd2f

Updated bundle.

cbb2a8a

updated gutenberg ref.

3a7ec29

fluiddot added 3 commits May 31, 2021 18:51

Update Gutenberg ref

9af4b59

Merge branch 'develop' into add/audio-block-capability

d959de8

# Conflicts: # bundle/ios/App.js # bundle/ios/App.js.map # gutenberg

Update bundle

47a11cc

fluiddot added 3 commits June 1, 2021 10:03

Update Gutenberg ref

b17c32f

Merge branch 'develop' into add/audio-block-capability

9fb590c

Update release notes

1a2ac0c

fluiddot reviewed Jun 1, 2021

View reviewed changes

fluiddot modified the milestones: 1.54.0 (17.5), 1.55.0 (17.6) Jun 1, 2021

Update bundle

1fe98d4

fluiddot approved these changes Jun 1, 2021

View reviewed changes

fluiddot added 2 commits June 3, 2021 10:14

Update Gutenberg ref

5cbd676

Update bundle

5fde7d0

fluiddot self-assigned this Jun 3, 2021

fluiddot added 4 commits June 3, 2021 10:37

Merge branch 'develop' into add/audio-block-capability

e0404ba

# Conflicts: # bundle/ios/App.js.map

Update Gutenberg ref

dd7c2bb

Update Gutenberg ref and bundle

c49a6e6

Update bundle and Gutenberg ref with merge commit

ab0fe0a

fluiddot merged commit 10eb321 into develop Jun 3, 2021

fluiddot deleted the add/audio-block-capability branch June 3, 2021 13:24

antonis mentioned this pull request Jun 11, 2021

Release 1.55.0 #3609

Merged

5 tasks

Conversation

jd-alexander commented May 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented May 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jd-alexander commented May 24, 2021

Uh oh!

fluiddot commented May 24, 2021

Uh oh!

jd-alexander commented May 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jd-alexander commented May 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jd-alexander commented May 27, 2021

Uh oh!

fluiddot commented May 27, 2021

Uh oh!

fluiddot commented May 27, 2021

Uh oh!

fluiddot commented May 31, 2021

Uh oh!

jd-alexander commented Jun 1, 2021

Uh oh!

fluiddot Jun 1, 2021

Choose a reason for hiding this comment

Uh oh!

fluiddot commented Jun 1, 2021

Uh oh!

fluiddot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jd-alexander commented May 19, 2021 •

edited

Loading

peril-wordpress-mobile bot commented May 19, 2021 •

edited

Loading

jd-alexander commented May 25, 2021 •

edited

Loading

jd-alexander commented May 27, 2021 •

edited

Loading