Skip to content

Slash inserter - Improve E2E #3549

Merged
geriux merged 6 commits intodevelopfrom
improve-slash-inserter-e2e
May 26, 2021
Merged

Slash inserter - Improve E2E #3549
geriux merged 6 commits intodevelopfrom
improve-slash-inserter-e2e

Conversation

@geriux
Copy link
Copy Markdown
Contributor

@geriux geriux commented May 25, 2021

Gutenberg PR -> WordPress/gutenberg#32186

To test, check the Canaries and the full tests pass correctly.

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Testing Anything related to automated tests label May 25, 2021
@geriux geriux marked this pull request as ready for review May 25, 2021 10:36
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented May 26, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux requested a review from fluiddot May 26, 2021 12:36
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#32186 (review).

I also checked the "UI tests - Canaries" and passed for both platforms 🟢 .

iOS Android
Screenshot 2021-05-26 at 16 36 42 Screenshot 2021-05-26 at 16 36 54

@geriux geriux merged commit e1d31a5 into develop May 26, 2021
@geriux geriux deleted the improve-slash-inserter-e2e branch May 26, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Anything related to automated tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants