Skip to content

UnitControl: Add support for unit step per unit type#3479

Closed
dcalhoun wants to merge 3 commits intodevelopfrom
update/unitcontrol
Closed

UnitControl: Add support for unit step per unit type#3479
dcalhoun wants to merge 3 commits intodevelopfrom
update/unitcontrol

Conversation

@dcalhoun
Copy link
Copy Markdown
Member

@dcalhoun dcalhoun commented May 11, 2021

Sibling to WordPress/gutenberg#30376. Opened to run all CI checks against the incoming change.

To test: Verify RangeCell and StepperCell continue to function as expected with no regressions.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

dcalhoun added 2 commits May 11, 2021 10:54
These match the changes from the Gutenberg project. https://git.io/Jsf4P
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented May 11, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun dcalhoun added the [Status] DO NOT MERGE Do not merge this PR label May 11, 2021
Unsure as to why multiple `npm install` runs occasionally produces
different outcomes.
@dcalhoun
Copy link
Copy Markdown
Member Author

The current failures in this PR are unrelated to the changes in WordPress/gutenberg#30376 and have been resolved in #3477. Closing this PR as it has served its purpose.

@dcalhoun dcalhoun closed this May 11, 2021
@dcalhoun dcalhoun deleted the update/unitcontrol branch May 11, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] DO NOT MERGE Do not merge this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant