Skip to content

Rich text: fix native block implementation#3477

Merged
dcalhoun merged 3 commits intodevelopfrom
fix/native-rich-text
May 11, 2021
Merged

Rich text: fix native block implementation#3477
dcalhoun merged 3 commits intodevelopfrom
fix/native-rich-text

Conversation

@fluiddot
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot commented May 11, 2021

gutenberg PR: WordPress/gutenberg#31690

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added [Type] Bug Something isn't working Web breakage Caused by incompatible changes on Gutenberg web labels May 11, 2021
@dcalhoun dcalhoun marked this pull request as ready for review May 11, 2021 14:44
Copy link
Copy Markdown
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved via WordPress/gutenberg#31690 (review). I'll update the gutenberg reference once the sibling PR has merged.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented May 11, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun dcalhoun enabled auto-merge May 11, 2021 15:09
These changes match those within the Gutenberg project.
https://git.io/Jsf4P
@dcalhoun dcalhoun merged commit ed7a64d into develop May 11, 2021
@dcalhoun dcalhoun deleted the fix/native-rich-text branch May 11, 2021 16:37
@fluiddot fluiddot added this to the 1.53.0 (17.4) milestone May 12, 2021
@AmandaRiu AmandaRiu mentioned this pull request May 14, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working Web breakage Caused by incompatible changes on Gutenberg web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants