Rich text: fix native block implementation#31690
Merged
Conversation
|
Size Change: -242 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
540cc33 to
c1c3e9f
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3477Description
Fixes #31684. Apparently there's breakage for the native editor after some rich text refactoring.
Creates a separate
.nativefile the implementation of rich text for blocks with how the code was before 90e50dc.Further refactoring of the web version of rich text will be done and the way rich text works is so different that it makes sense to have separate files for each platform.
When core rich text becomes stable (currently experimental, but soon planned to be stable), we could look at making more things common.
How has this been tested?
It would be good to have more native test coverage.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).