Conversation
655bb18 to
7fe3a47
Compare
4 tasks
Tug
commented
Dec 3, 2018
| <PROJECT_ROOT>/node_modules/fbjs/.* | ||
| <PROJECT_ROOT>/node_modules/graphql/.* | ||
| <PROJECT_ROOT>/node_modules/prettier/.* | ||
| <PROJECT_ROOT>/node_modules/jsx-to-string/.* |
Contributor
Author
There was a problem hiding this comment.
Seems like those are necessary sometimes, let's just add those
267b43f to
42fd5c4
Compare
…t of metro-react-native-babel-preset
42fd5c4 to
734b021
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires WordPress/gutenberg#12552
Fix "Block validation failed for
core/paragraph... " errors when trying the demo post content from gutenberg.For this we remove the babel transform
react-native-classname-to-stylewhich would cause unexpected result when saving blocks and thus validation errors.This PR also removes some unused dependencies and others that are already provided by
@wordpress/babel-preset-default.Lastly, it updates the
initial-html.jsand appends the whole content of the gutenberg demo post which can be found here https://wordpress.org/gutenberg/