Skip to content

Stop using classname-to-style autotransform in react native#12552

Merged
Tug merged 1 commit intomobilefrom
rnmobile/fix/validation-errors
Dec 4, 2018
Merged

Stop using classname-to-style autotransform in react native#12552
Tug merged 1 commit intomobilefrom
rnmobile/fix/validation-errors

Conversation

@Tug
Copy link
Copy Markdown
Contributor

@Tug Tug commented Dec 3, 2018

Description

At some point, we added the react-native-classname-to-style babel transform to transform className jsx attributes into style. This causes problems as it's also transformed in the blocks save function. A better approach is to use style explicitly instead.

How has this been tested?

Tested with wordpress-mobile/gutenberg-mobile#310

Types of changes

  • Mobile compatibility changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants