Skip to content

Fix/25873 unsupported block bottom sheet is triggered when device is rotated#2710

Merged
marecar3 merged 5 commits intodevelopfrom
fix/25873_Unsupported_block_bottom_sheet_is_triggered_when_device_is_rotated
Oct 13, 2020
Merged

Fix/25873 unsupported block bottom sheet is triggered when device is rotated#2710
marecar3 merged 5 commits intodevelopfrom
fix/25873_Unsupported_block_bottom_sheet_is_triggered_when_device_is_rotated

Conversation

@marecar3
Copy link
Copy Markdown
Contributor

@marecar3 marecar3 commented Oct 12, 2020

Fixes wordpress-mobile/WordPress-Android#13052

Fellow Gutenberg PR: WordPress/gutenberg#25873

To test:

  1. Open the block editor on a post that contains an unsupported block (e.g. Audio is a block that's not yet supported on mobile at time of writing)
  2. With the editor open, rotate the device and notice the bottom sheet should not appear

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@marecar3 marecar3 added this to the 1.39 milestone Oct 12, 2020
@marecar3 marecar3 self-assigned this Oct 12, 2020
@marecar3 marecar3 mentioned this pull request Oct 12, 2020
Merged
6 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Oct 12, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun
Copy link
Copy Markdown
Contributor

ceyhun commented Oct 12, 2020 •
edited
Loading

@marecar3 We'll be cutting the 1.39 release soon, you have 3 options:

  1. merge the PR as soon as possible
  2. bump the PR to the next milestone
  3. remove the milestone from the PR

@guarani
Copy link
Copy Markdown
Contributor

guarani commented Oct 12, 2020 •
edited
Loading

Testing this now (cc @marecar3)
Update: comment left here: WordPress/gutenberg#25873 (review)

mchowning
mchowning approved these changes Oct 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well for me. But let's wait to hear what @guarani thinks before merging this.

@marecar3
Merge branch 'develop' into fix/25873_Unsupported_block_bottom_sheet_…
93b5dca 
…is_triggered_when_device_is_rotated

# Conflicts:
#	gutenberg
guarani
guarani approved these changes Oct 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#25873 (review)

@marecar3 marecar3 merged commit 86ebe08 into develop Oct 13, 2020
@marecar3 marecar3 deleted the fix/25873_Unsupported_block_bottom_sheet_is_triggered_when_device_is_rotated branch October 13, 2020 01:05
This was referenced Oct 13, 2020
Merged
Merged
@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Oct 16, 2020

@marecar3 - Did this fix solve this ticket too? #2680
It was mentioned that they could be related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etoledom etoledom Awaiting requested review from etoledom

2 more reviewers

@guarani guarani guarani approved these changes

@mchowning mchowning mchowning approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marecar3 marecar3

Labels

None yet

Projects

None yet

Milestone

1.39

Development

Successfully merging this pull request may close these issues.

Unsupported block bottom sheet is triggered when device is rotated

5 participants

@marecar3 @ceyhun @guarani @etoledom @mchowning