Skip to content

Dynamically search for plugin-proposal-async-generator-functions#2662

Merged
chipsnyder merged 5 commits intodevelopfrom
fix/dynamicBabelPath
Sep 24, 2020
Merged

Dynamically search for plugin-proposal-async-generator-functions#2662
chipsnyder merged 5 commits intodevelopfrom
fix/dynamicBabelPath

Conversation

@chipsnyder
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder commented Sep 23, 2020

Gutenberg: WordPress/gutenberg#25588

Fixes an error related to missing module @babel/plugin-proposal-async-generator-functions

To test:

  • npm install
  • npm start
  • Check that the editor loads
  • Stop Metro
  • npm run core start
  • Check that the editor loads

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added dependencies Pull requests that update a dependency file Web breakage Caused by incompatible changes on Gutenberg web labels Sep 23, 2020
@chipsnyder chipsnyder requested a review from etoledom September 23, 2020 21:09
This was referenced Sep 23, 2020
Merged
Closed
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 23, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@malinajirka malinajirka mentioned this pull request Sep 24, 2020
Merged
3 tasks
etoledom
etoledom approved these changes Sep 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#25588 (review)

Thank you! 🙏

@chipsnyder chipsnyder merged commit 9ad8e55 into develop Sep 24, 2020
@chipsnyder chipsnyder deleted the fix/dynamicBabelPath branch September 24, 2020 12:17
@etoledom etoledom mentioned this pull request Oct 1, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file Web breakage Caused by incompatible changes on Gutenberg web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chipsnyder @etoledom