Size Change: -8 B (0%)

Total Size: 1.17 MB

_{compressed-size-action}

👋 @chipsnyder (or @etoledom ), wondering if you have some insight on what's the issue here and how the fix ends up fixing it? Curious whether we missing something here 🤔

@hypest - From what I understood, previously @babel/plugin-proposal-async-generator-functions was a direct dependency of gutenberg-mobile so babel was able to find it as @babel/plugin-proposal-async-generator-functions. Now it is a dependency of @wordpress/babel-preset-default.

I don't know why this change happened, but it seems to come from this PR: #25351 (It looks like a simple version update. Npm works on mysterious ways to me).

Even though we have @wordpress/babel-preset-default as a dependency, now Babel can't find @babel/plugin-proposal-async-generator-functions directly, so we tell it the path of where to find it.

This is roughly my understand and I can be wrong, but it kinds of make sense to me.

All this info can be seen in the diff on gutenberg-mobile/package-lock.json. It was autogenerated after npm install with an updated gutenberg reff.

Hey @hypest,
@etoledom's explanation is right on for everything I found as well. The only things I would add is "lookup" needs to provide enough hints in the form of ../ to be able to find the correct node_modules folder as it seems to matter if I'm running npm start, npm run core start or running as the e2e tests.

Npm works on mysterious ways to me

Same here 😄 We also considered adding the dependency directly to gutenberg-mobile, which also worked fine. However, I feel like this update is more in line with the change that sparked the need.