Skip to content

Disable Page Template picker if modal layout picker is available (Update for new capabilities mechanism)#2505

Merged
chipsnyder merged 2 commits intodevelopfrom
mobile/issue/2419-capabilities
Jul 28, 2020
Merged

Disable Page Template picker if modal layout picker is available (Update for new capabilities mechanism)#2505
chipsnyder merged 2 commits intodevelopfrom
mobile/issue/2419-capabilities

Conversation

@chipsnyder
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder commented Jul 23, 2020

Fixes: #2419

Related PRs:

Description

This capability was originally tested as part of #2478 this just serves as the update to migrate that strategy to be in line with recent changes.

Below is the description and testing steps from the original PR.


Description

This change enables the mobile editor to accept the capability modalLayoutPicker and based on that conditionally show or hide the Template Picker.

Android hasn't started Modal Layout Picker yet so this only needs to

How has this been tested?

To disable or enable the development version of Modal Layout Picker

On iOS using the build options mentioned above

  • With Gutenberg Modal Layout Picker toggled on:

    • Select to create a new page
    • Expect to see the container for the new modal Layout Picker
    • Select "Create Blank Page"
    • Expect the current template picker to be hidden
  • With Gutenberg Modal Layout Picker toggled on:

    • Select an existing page or draft without content (just a title)
    • You should not see the new Modal Layout Picker
    • Expect the current template picker to be hidden
  • With Gutenberg Modal Layout Picker toggled off:

    • Select to create a new page
    • You should not see the new Modal Layout Picker
    • Expect the current template picker to be shown.
  • With Gutenberg Modal Layout Picker toggled off:

    • Select an existing page or draft without content (just a title)
    • You should not see the new Modal Layout Picker
    • Expect the current template picker to be shown
  • With Gutenberg Modal Layout Picker toggled on or off:

    • Select an existing page or draft with content
    • Expect the current template picker to be hidden

On Android running a metro server or generating a build

  • Existing Blank Page
    • Select an existing page or draft without content (just a title)
    • Expect the current template picker to be shown
  • New Page
    • Select to create a new page
    • Expect the current template picker to be shown.
  • Existing Page
    • Select an existing page or draft with content
    • Expect the current template picker to be hidden

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to [RELEASE-NOTES.txt](RELEASE-NOTES.txt) if necessary.

Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peril-wordpress-mobile
Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@chipsnyder chipsnyder merged commit 75ddd7f into develop Jul 28, 2020
@chipsnyder chipsnyder deleted the mobile/issue/2419-capabilities branch July 28, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Modal Layout Picker] Create Modal window for Modal Layout Picker

2 participants