Disable Page Template picker if modal layout picker is available#2478
Merged
chipsnyder merged 4 commits intodevelopfrom Jul 15, 2020
Merged
Disable Page Template picker if modal layout picker is available#2478chipsnyder merged 4 commits intodevelopfrom
chipsnyder merged 4 commits intodevelopfrom
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
6 tasks
3 tasks
Contributor
Author
|
The iOS PR is still in design review but this can be reviewed and merged separately from that. |
geriux
approved these changes
Jul 15, 2020
Contributor
geriux
left a comment
There was a problem hiding this comment.
Approved via WordPress/gutenberg#23872 (review)
Contributor
Author
|
There seems to be a sync issue here as the PR isn't showing the merge commit. Closing and reopening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2419
Related PRs:
gutenberg: Disable Page Template picker if modal layout picker is available WordPress/gutenberg#23872WordPress-iOS: Create Modal Layout Picker Container for new Gutenberg pages and feature flag for development WordPress-iOS#14456Description
This change enables the mobile editor to accept the capability
modalLayoutPickerand based on that conditionally show or hide the Template Picker.Opening this PR to generate a bundle so that the toggle in iOS is testable.
How has this been tested?
To disable or enable the development version of Modal Layout Picker
To toggle:
On iOS using the build options mentioned above
With Gutenberg Modal Layout Picker toggled on:
With Gutenberg Modal Layout Picker toggled on:
With Gutenberg Modal Layout Picker toggled off:
With Gutenberg Modal Layout Picker toggled off:
With Gutenberg Modal Layout Picker toggled on or off:
On Android running a metro server or generating a build
PR submission checklist:
[RELEASE-NOTES.txt](RELEASE-NOTES.txt)if necessary.